Cloud mask task should use s2cloudless #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #723 +/- ##
========================================
Coverage 88.71% 88.71%
========================================
Files 57 57
Lines 5652 5652
========================================
Hits 5014 5014
Misses 638 638 ☔ View full report in Codecov by Sentry. |
zigaLuksic
reviewed
Aug 25, 2023
zigaLuksic
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
eo-learn-mask(s2cloudless)CloudMaskTaskafter usingS2PixelCloudDetectorfroms2cloudlessI expected the test data to change and the tests to fail, since the eo-learn version was using a different version of the s2cloudless model (or seemed to be). Doesn't seem to be any change in the tests, so this one is a freebie.